Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SIGINT on windows #300

Open
sdstolworthy opened this issue Sep 27, 2023 · 0 comments
Open

Handle SIGINT on windows #300

sdstolworthy opened this issue Sep 27, 2023 · 0 comments
Labels
tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later testing Engineering label for issues related to tests or test tooling

Comments

@sdstolworthy
Copy link
Contributor

See #254 (comment)
and #254 (comment)

Our test runner uses taskkill to interrupt the Sandbox watcher. This kills the node process without allowing the event queue to drain, leaving unresolved promises. In Sandbox, this is manifested by the post-deployment sandbox events not finishing before the process is killed. This causes tests to fail which rely on the presence of the client configuration generated in the after deployment event handler.

Right now, this is naively addressed by hardcoding a wait time in the code. This should be refactored to allow a more flexible approach. Either our Process interactor should be able to send "wait" interactions, or we should find a more elegant way to kill the process on windows.

@sdstolworthy sdstolworthy added tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later testing Engineering label for issues related to tests or test tooling labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later testing Engineering label for issues related to tests or test tooling
Projects
None yet
Development

No branches or pull requests

1 participant