Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for integration test utilities #315

Open
edwardfoyle opened this issue Sep 28, 2023 · 1 comment
Open

Write tests for integration test utilities #315

edwardfoyle opened this issue Sep 28, 2023 · 1 comment
Assignees
@bombguy
Labels
tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later testing Engineering label for issues related to tests or test tooling

Comments

@edwardfoyle
Copy link
Contributor

we should have unit tests for the parts of our integration testing harness that have non-trivial code. Eg https://github.com/aws-amplify/samsara-cli/pull/307/files#diff-434508ac1d42c20546c7cf5bb6698a1c7addf244e1f560d6665a59720f47ddf6
@edwardfoyle edwardfoyle added tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later testing Engineering label for issues related to tests or test tooling labels Sep 28, 2023
@edwardfoyle edwardfoyle mentioned this issue Sep 28, 2023
Merged
@edwardfoyle
Copy link
Contributor Author

Add tests for process controller and other goodies here https://github.com/aws-amplify/amplify-backend/tree/main/packages/integration-tests/src/process-controller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bombguy bombguy

Labels
tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later testing Engineering label for issues related to tests or test tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bombguy @edwardfoyle