Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AWS SDK bundling in branch linker. #561

Open
sobolk opened this issue Nov 2, 2023 · 0 comments
Open

Remove AWS SDK bundling in branch linker. #561

sobolk opened this issue Nov 2, 2023 · 0 comments
Labels
dependency Issue related to upstream dependency performance Optimizations in code paths tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later

Comments

@sobolk
Copy link
Member

sobolk commented Nov 2, 2023 •
edited
Loading

Related to: #554 (comment) .
And #562

We're adding workaround recommended here aws/aws-cdk#26681 (comment) .

When Lambda serves SDK 3.440.0+ we should remove local SDK bundling.

When we do this we should:

  1. Remove bundling of AWS SDK in AmplifyBranchLinkerConstruct
  2. Move @aws-sdk/client-amplify to devDependencies in @aws-amplify/backend
@sobolk sobolk added dependencies tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later performance Optimizations in code paths labels Nov 2, 2023
@sobolk sobolk mentioned this issue Nov 2, 2023
Merged
@edwardfoyle edwardfoyle added dependency Issue related to upstream dependency and removed dependencies labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependency Issue related to upstream dependency performance Optimizations in code paths tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolk @edwardfoyle