Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pr size check incorrectly classifies file renames as 'adds' for the size of the file. #602

Open
alharris-at opened this issue Nov 7, 2023 · 0 comments
Open

pr size check incorrectly classifies file renames as 'adds' for the size of the file. #602

alharris-at opened this issue Nov 7, 2023 · 0 comments
Labels
good first issue Good for newcomers tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later testing Engineering label for issues related to tests or test tooling

Comments

@alharris-at
Copy link
Contributor

Because we only look at the files that exist AFTER the change is made, and not those which were previously defined before the rename, we incorrectly call these renames large 'adds'.

We probably just need to update how the diffFileList is produced.
@edwardfoyle edwardfoyle added tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later testing Engineering label for issues related to tests or test tooling labels Nov 28, 2023
@edwardfoyle edwardfoyle added the good first issue Good for newcomers label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later testing Engineering label for issues related to tests or test tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edwardfoyle @alharris-at