Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge cases with customers exiting sandbox while CFN deployment is in progress #729

Open
Amplifiyer opened this issue Nov 21, 2023 · 0 comments
Assignees
Labels
bug Something isn't working sandbox Related to the sandbox experience

Comments

@Amplifiyer
Copy link
Contributor

Environment information

N/A

Description

While sandbox is performing a CFN deployment (not hotswap) through CDK, customers can CTRL-C and not delete the sandbox letting the CFN deployment continue at the server end (We don't cancel deployments when customer exits sandbox)

Now if customer runs the sandbox again, sandbox detects that there is ongoing CFN deployment, print warning to the customer and wait for further changes from customers. At this point, if customers do not make any changes to their files, their amplifyconfiguration doesn't get updated. This is because sandbox after getting restarted, is no longer listening for events from the previous deployment. This gets remedied automatically if customer makes any change after the previous deployment finishes.

There are few things we can do here:

  1. Update the error message to let customers know and direct them to use the generate client-config command.
  2. Build mechanism to "connect" to the CFN deployment (net new CFN service poller) since CDK CLI doesn't connect (doesn't even fail or tell customers that a deployment is in progress and silently quits)
@Amplifiyer Amplifiyer added the pending-triage Incoming issues that need categorization label Nov 21, 2023
@edwardfoyle edwardfoyle added bug Something isn't working sandbox Related to the sandbox experience and removed pending-triage Incoming issues that need categorization labels Nov 28, 2023
@ykethan ykethan added the p2 label Dec 13, 2023
@ykethan ykethan added p3 and removed p2 labels Mar 12, 2024
@AnilMaktala AnilMaktala removed the p3 label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sandbox Related to the sandbox experience
Projects
None yet
Development

No branches or pull requests

4 participants