Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message on do_include_e2e job when PR is from fork #781

Open
edwardfoyle opened this issue Dec 5, 2023 · 0 comments
Open
Labels
good first issue Good for newcomers tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later testing Engineering label for issues related to tests or test tooling

Comments

@edwardfoyle
Copy link
Contributor

edwardfoyle commented Dec 5, 2023

Description

Our e2e tests can only be run on branches in the repo because the e2e tests have access to our test AWS account. If a PR from a fork tries to run the e2e tests (by adding the run-e2e label to the PR) it fails with a cryptic error message: https://github.com/aws-amplify/amplify-backend/actions/runs/7107074005/job/19349478710

We should instead add logic to the do_include_e2e workflow to check if the PR is from a fork and throw a helpful error

@edwardfoyle edwardfoyle added good first issue Good for newcomers testing Engineering label for issues related to tests or test tooling labels Dec 5, 2023
@josefaidt josefaidt added the tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later testing Engineering label for issues related to tests or test tooling
Projects
None yet
Development

No branches or pull requests

2 participants