[DBInstance] Support for Oracle Multitenant SID #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parker4cpk
reviewed
Nov 4, 2024
...dbinstance/src/main/java/software/amazon/rds/dbinstance/validators/OracleCustomSystemId.java
Show resolved
Hide resolved
angusy29
force-pushed
the
oracle-custom-sid
branch
2 times, most recently
from
a6a8c28
to
06df661
Compare
angusy29
force-pushed
the
oracle-custom-sid
branch
from
06df661
to
804ee9d
Compare
parker4cpk
approved these changes
Nov 5, 2024
ccmlst
reviewed
Nov 7, 2024
...dbinstance/src/main/java/software/amazon/rds/dbinstance/validators/OracleCustomSystemId.java
Show resolved
Hide resolved
zrfr
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
DBSystemId is a property used to customise RDS Oracle Custom container databases' system id.
This is a createOnlyProperty which requires replacement of the DBInstance resource if the customer attempts to rename it.
Because DBSystemId is only passed in on create-db-instance, it means that there is potential for open fail scenarios, where user sets the DBSystemId and sees no results.
For example: We want to block users from being able to set a DBSystemId for read replicas, restore from PITR and restore from snapshot