Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine linux: tabs at the end of line breaks the linter #666

Open
Sergei-Rudenkov opened this issue Feb 19, 2019 · 5 comments
Open

Alpine linux: tabs at the end of line breaks the linter #666

Sergei-Rudenkov opened this issue Feb 19, 2019 · 5 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Sergei-Rudenkov
Copy link

Environment: cfn-lint v0.14.0, docker image: alpine3.8, python alpine version: 3.6.6-r0

content of cfn.yaml:

---
AWSTemplateFormatVersion: '2010-09-09'		
#...	see tabs the end of previous line 	

Execution command: python3 -m cfnlint -t cfn.yaml

Actual result:

E0000 Expecting value
.cfn.yaml:1:1

screenshot

@kddejong kddejong self-assigned this Feb 24, 2019
@kddejong kddejong added the bug Something isn't working label Feb 24, 2019
@kddejong
Copy link
Contributor

Seems to be just an Alpine thing but was able to replicate this. Going to have to do some more digging to understand why.

@kddejong
Copy link
Contributor

Actually so more testing has revealed this is a difference between the C yaml parser and the native python yaml parser. I can now replicate this on a mac when forcing to not use the yaml.cyaml

@kddejong
Copy link
Contributor

yaml/pyyaml#116 looks like the issue tracking yaml 1.2 support in pyyaml or we would have to look into switching to ruamel.yaml

@andrew-glenn
Copy link
Contributor

@kddejong - We're considering a move to runamel soon as well. Anecdotal commentary.

@kddejong
Copy link
Contributor

yea I was looking into that. Since we did some manipulation of the pyyaml parser I'm going to have to see how compatible ruamel.yaml will be. Considering the length of the issue alternative options may be needed.

@PatMyron PatMyron added the wontfix This will not be worked on label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants