Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceTimeout rule #3848

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ConnorKirk
Copy link

Issue #, if available:
#3834
Description of changes:

The ServiceTimeout rule emits a warning if the ServiceTimeout property is not specified for a CloudFormation Custom Resource.

  • Add new ServiceTimeout Class
  • Add test_service_timeout unit test
  • Add good/bad fixtures service_timeout.py

Todo

  • Fix tests. A few seem to be broken by this new rule
  • Double check the ID
  • Add the rule to the rules.md?

Notes

  • I picked a rule id that seemed available. I wasn't clear if there was a reason for the jump from W045 to W3663. A different ID might be more suitable
  • This could be a warning or information level rule. I'm leaning towards warning.
  • CloudFormation Custom Resources have multiple possible resourcetypes, either AWS::CloudFormation::CustomResource, a custom resource type, prefixed wit Custom::. I added a small helper function to find all custom resources

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ConnorKirk ConnorKirk force-pushed the add-service-timeout-rule branch from 7dd8d15 to a8c746e Compare December 2, 2024 15:01
The ServiceTimeout rule emits a warning if the ServiceTimeout property is not specified for a CloudFormation Custom Resource.
@ConnorKirk ConnorKirk force-pushed the add-service-timeout-rule branch from a8c746e to e96161f Compare December 2, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant