Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip findinmap resolution when hitting a Sub #3856

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Dec 5, 2024

Issue #, if available:
fix #3847
Description of changes:

  • Skip findinmap resolutions when using a Sub

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.78%. Comparing base (19192ef) to head (0fff407).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cfnlint/context/context.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3856      +/-   ##
==========================================
- Coverage   93.78%   93.78%   -0.01%     
==========================================
  Files         364      364              
  Lines       12463    12476      +13     
  Branches     2556     2561       +5     
==========================================
+ Hits        11689    11701      +12     
  Misses        429      429              
- Partials      345      346       +1     
Flag Coverage Δ
unittests 93.74% <88.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit e79baed into aws-cloudformation:main Dec 6, 2024
23 of 24 checks passed
@kddejong kddejong deleted the fix/issue/3847 branch December 6, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cfn-lint incorrectly issues E1011 (FindInMap validation of configuration) with !Sub referencing AWS::AccountId
1 participant