Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MariaDB #717

Closed
robertsilen opened this issue Jan 10, 2025 · 3 comments
Closed

MariaDB #717

robertsilen opened this issue Jan 10, 2025 · 3 comments

Comments

@robertsilen
Copy link
Contributor

Hello, retail-store-sample-app is using MariaDB, see: https://github.com/aws-containers/retail-store-sample-app/blob/main/deploy/docker-compose/docker-compose.yml#L50

It would be appropriate to add MariaDB to the READM and any documentation where the database is mentioned. Ok if I do a PR for it?
@robertsilen
Copy link
Contributor Author

It would also be correct for the graph to be updated to mention MariaDB: https://github.com/aws-containers/retail-store-sample-app/blob/main/docs/images/architecture.png

@robertsilen robertsilen mentioned this issue Jan 10, 2025
Merged
@niallthomson
Copy link
Collaborator

Hey @robertsilen I'm working on a revamping of the sample and will address the diagram as part of this

@niallthomson niallthomson mentioned this issue Feb 26, 2025
Merged
@niallthomson
Copy link
Collaborator

Fixed in v1 #742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niallthomson @robertsilen