Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: missing adaptor environment enter and exit timeouts #116

Open
joel-wong-aws opened this issue Feb 11, 2025 · 0 comments
Open

Bug: missing adaptor environment enter and exit timeouts #116

joel-wong-aws opened this issue Feb 11, 2025 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@joel-wong-aws
Copy link
Contributor

joel-wong-aws commented Feb 11, 2025

Describe the bug

The Unreal adaptor's environment enter and exits do not have a timeout specified in their job template.

Expected Behaviour

The timeout for the environment enter should be a little more (ex. 1 minute) than the server start timeout + Unreal start timeout. The timeout for the environment exit should be a little more (ex. 1 minute) than the server end timeout + Unreal end timeout

Current Behaviour

If the environment enter or exit get stuck (and the first layer of timeouts doesn't work), then the worker agent does not enforce the timeout.

Proposed Solution

Add a timeout to the environment enter and exit actions here, using the OpenJD spec timeout field.

Environment

  1. Operating system (e.g. Windows Server 2022; Amazon Linux 2023; etc.): affects all rendering OSes
  2. Version of Unreal Engine: affects all versions of Unreal
  3. Version of this package: affects all versions
  4. If this is from a version installed by the Deadline Cloud Submitter installer, then what version of the submitter installer? N/A

Example PR: aws-deadline/deadline-cloud-for-cinema-4d#173

@joel-wong-aws joel-wong-aws added bug Something isn't working needs triage A new issue that needs a first look good first issue Good for newcomers and removed needs triage A new issue that needs a first look labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant