Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Metrics value level validation on the test cases with live backends #302

Open
mxiamxia opened this issue May 17, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@mxiamxia
Copy link
Member

mxiamxia commented May 17, 2021

There are some components(AWS) are testing against Live backend. We should enable metric value level validation for these test cases,

  • EMFExporter
  • XRayExporter
  • AMPRemoteWriterExporter
@vasireddy99
Copy link
Contributor

vasireddy99 commented Mar 20, 2022

Looking at this issue, means to make this parameter to true for using this method for the comparison. Is the strict comparison method is necessary or recommended, since my understanding from the test framework is we are comparing the Metric names and labels, can be considered as sufficient?. Since i could see the current test framework is not using the strict comparison for any/most tests cases at the moment, would be good to know your suggestions. sorry if am missing anything here .

@vasireddy99 vasireddy99 added enhancement New feature or request labels Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants