Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use 1password for passkey #147

Open
jplock opened this issue Feb 18, 2024 · 8 comments
Open

Unable to use 1password for passkey #147

jplock opened this issue Feb 18, 2024 · 8 comments

Comments

@jplock
Copy link

jplock commented Feb 18, 2024

Whenever I try to register a passkey saved in 1Password, this error message is shown in the UI:

Failed to activate face or touch unlock: credential.response is not an instance of AuthenticatorAttestationResponse

1Password is successfully saving the passkey though.

@ottokruse
Copy link
Contributor

Mmm not the first time we see 1password being idiosyncratic: #94

They inject themselves into the browser, but don't do so fully transparently. You should file an issue with them as well

@jplock
Copy link
Author

jplock commented Feb 18, 2024

Strange, it works fine with Safari and 1Password, but not Firefox and 1Password

@ottokruse
Copy link
Contributor

ottokruse commented Feb 19, 2024

Instead of doing the instanceof checks we could check the interface (duck typing):

if (
!(credential instanceof PublicKeyCredential) ||
!(credential.response instanceof AuthenticatorAttestationResponse)
) {
throw new Error(
"credential.response is not an instance of AuthenticatorAttestationResponse"
);
}

if (
!(credential instanceof PublicKeyCredential) ||
!(credential.response instanceof AuthenticatorAssertionResponse)
) {
throw new Error(
"credential.response is not an instance of AuthenticatorAssertionResponse"
);
}

@ottokruse
Copy link
Contributor

But as said, you should file this with 1Password as well

@myevit
Copy link

myevit commented Feb 29, 2024

I have no issues using 1Password for passkeys. Looks like localized issue. 1Password browser extension issues?

@ottokruse
Copy link
Contributor

You use Firefox too @myevit ?

@myevit
Copy link

myevit commented Mar 1, 2024

I use 3: Edge, Crome and Firefox. No issues with all of them with 1Password.
there were some behaviour that browser bypassing 1Password passkey hook and go straight to system passkey UI, but so far I can tell, it is not an issue of your app.

@myevit
Copy link

myevit commented Mar 13, 2024

Update: Firefox start to give me credential.response is not an instance of AuthenticatorAssertionResponse error on filling out 1Password passkey. It might be happening long time ago, I do use Firefox only for developing.
What's weird is that it's working on as dev on http://localhost:5173 but deployed to cloud. Edge has no issues.
Windows Hello seems have no issues... Probably some 1Password extension bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants