-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add patterns for argo addon management #59
Conversation
CI is failing because the depending feature is not released: aws-quickstart/cdk-eks-blueprints#588 . Will update this PR once the PR is merged. |
@shapirov103 This PR added two patterns as examples of using GitOps addons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@starchx looks great as far as code. I do want to have some GTM component for this as well. Let's add the pattern description to the documentation README.md and under docs/patterns. We will be converting it to mkdocs and publish on gh pages soon.
I am running validations on both patterns now.
}); | ||
|
||
// AddOns for the cluster. | ||
const addOns: Array<blueprints.ClusterAddOn> = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all add-ons worked fine. What is the list of supported add-ons atm? Don't expect you to remember on top of your head, but if you can point to some that are not supported, don't work, please let me know.
This PR has been automatically marked as stale because it has been open 60 days |
@starchx There is no traction on this PR for 6 months now. Could you please work on this if this feature is still needed.? |
This PR has been automatically marked as stale because it has been open 60 days |
@starchx There is no traction on this PR for 9 months now. Could you please work on this if this feature is still needed.? |
This PR has been automatically marked as stale because it has been open 60 days |
@starchx There is no traction on this PR for 9 months now. Could you please work on this if this feature is still needed.? |
This PR has been automatically marked as stale because it has been open 60 days |
This PR has been automatically marked as stale because it has been open 60 days |
Pull request closed due to inactivity. |
Issue #, if available:
Description of changes:
Added two patterns for ArgoCD addon management.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.