UnboundLocalError from index.handler during deployment

[MustaphaU]

When deploying the Retail Demo Store, the following error is encountered when retries are exhausted during the execution of the handler function in the LoadDataLambdaFunction in deployment-support.yaml.

Error

 UnboundLocalError: cannot access local variable 'e' where it is not associated with a value
 Traceback (most recent call last):
   File "/var/task/index.py", line 31, in handler
     logger.error(f"Error calling product service init: {e.code} : {e.reason}")

The relevant code block:

...
while retries < max_retries:
      try:
          with urlopen(request) as response:
              logger.info(f"Product Service init method success: {response.read()}")
              # exit while, success.
              break
      except URLError as e:
          retries += 1
          print(f"Request failed. Retrying in 30 seconds... (Attempt {retries}/{max_retries})")
          print(f"Error: {e}")
          time.sleep(30)

#
if retries >= max_retries:
    logger.error(f"Error calling product service init: {e.code} : {e.reason}")
    response_status = cfnresponse.FAILED
    response_data['Message'] = f"Resource {event['RequestType']} failed: {e}"  
...      

The scope of e is local to the except block and Python does not persist it outside that scope. The condition if retries >= max_retries runs outside the loop and, therefore, cannot access e. The value (e) within the block can be assigned to a variable to be accessed outside.

[berry2012]

I got the same error as well

@log	
XXXXXXXXXX:/aws/lambda/retaildemostore-DeploymentS-LoadDataLambdaFunction-Yb5K2S2Y3jVk
@logStream	
2024/12/02/[$LATEST]c0262b725f6646148b67ed17c687ca39
@message	
[ERROR] UnboundLocalError: cannot access local variable 'e' where it is not associated with a value
Traceback (most recent call last):
  File "/var/task/index.py", line 31, in handler
    logger.error(f"Error calling product service init: {e.code} : {e.reason}")

[BastLeblanc]

Thanks for the report.
The underline issue on the product service is fixed by #670

Thanks for the PR #669 will review it asap