Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate fileType also when MQTT protocol is in use #114

Open
ileonovAmzn opened this issue Feb 3, 2025 · 1 comment
Open

Populate fileType also when MQTT protocol is in use #114

ileonovAmzn opened this issue Feb 3, 2025 · 1 comment

Comments

@ileonovAmzn
Copy link

Currently in job_parser.c, fileType field from the job document is only parsed and populated into the AfrOtaJobDocumentFields_t struct if protocol value is not "MQTT": it is done in populateHttpStreamingFields().

In AWS IoT Core console, when creating an OTA job, fileType can be populated also when MQTT protocol is selected for the job.

We are using the Jobs-for-AWS-IoT-embedded-sdk library with a job over MQTT protocol and we would like to set fileType value in the job document to indicate to our OTA agent what type of content the job has.

I suggest to move fileType parsing code to populateCommonFields() from populateHttpStreamingFields().

@kstribrnAmzn
Copy link
Member

Thanks for submitting the issue! This seems like a reasonable change. I'm reaching out to the jobs team to verify the filetype is always included for both MQTT and HTTP transmission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants