Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-timestream): Add support for CfnDBParameterGroup of Timestream InfluxDb #31862

Open
2 tasks
dang312 opened this issue Oct 23, 2024 · 3 comments
Open
2 tasks
Labels
@aws-cdk/aws-timestream Related to the @aws-cdk/aws-timestream package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p3

Comments

@dang312
Copy link

dang312 commented Oct 23, 2024

Describe the feature

Currently, we don't have any feature to create a database parameter group using CDK following this guide
https://docs.aws.amazon.com/timestream/latest/developerguide/timestream-for-influx-db-connecting.html#timestream-for-influx-parameter-groups-overview-default-custom-parameter-groups
We have to do it manually and after that edit the dbParameterGroupIdentifier of CfnInfluxDBInstance

Use Case

Create a database parameter group with CDK

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.126.0 (build fb74c41)

Environment details (OS name and version, etc.)

Linux

@dang312 dang312 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 23, 2024
@github-actions github-actions bot added the @aws-cdk/aws-timestream Related to the @aws-cdk/aws-timestream package label Oct 23, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 23, 2024
@khushail khushail self-assigned this Oct 23, 2024
@khushail
Copy link
Contributor

Hey @dang312 , thanks for reaching out. So what you are saying is you need a L2 construct for CfnInfluxDBInstance, which makes sense.

But please correct my understanding here when you mentioned you create the instance and the edit the identifier. With the support of L1 construct as CfnInfluxDBInstance, you should be able to create the one from scratch as well, as given in the example here.

Is that not doable ?

@khushail khushail added p3 effort/small Small work item – less than a day of effort response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Oct 23, 2024
@dang312
Copy link
Author

dang312 commented Oct 24, 2024

Hey @dang312 , thanks for reaching out. So what you are saying is you need a L2 construct for CfnInfluxDBInstance, which makes sense.

But please correct my understanding here when you mentioned you create the instance and the edit the identifier. With the support of L1 construct as CfnInfluxDBInstance, you should be able to create the one from scratch as well, as given in the example here.

Is that not doable ?

Actually no, L2 construct for CfnInfluxDbInstance is very helpful.
But what is need is the support of creating CfnDBParameterGroup automatically ( like RDS, Elasticache,.. ) instead of manual and assign the identifier like right now.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Oct 24, 2024
@khushail
Copy link
Contributor

@dang312 thanks for clarification around your usecase. So your point is to get construct like this- CfnDBParameterGroup.

For Timestream,there is no L1 construct supported by cloudformation and unless cloudformation provides it, it can not be supported by CDK.

You would have to create a request on the cloudformation coverage roadmap and follow that for further updates.
You could also help in prioritizing the request by getting upvotes from the community.

Hope that would be helpful.

@khushail khushail removed their assignment Oct 29, 2024
@khushail khushail added the needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-timestream Related to the @aws-cdk/aws-timestream package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p3
Projects
None yet
Development

No branches or pull requests

2 participants