-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudformation-include): string arrays inside unknown properties cannot be parsed #32461
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32461 +/- ##
==========================================
- Coverage 78.67% 78.66% -0.02%
==========================================
Files 107 107
Lines 7237 7237
Branches 1329 1329
==========================================
- Hits 5694 5693 -1
- Misses 1357 1358 +1
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
|
"NonExistentResourceAttribute": "Bucket1" | ||
"ResourceSignal": { | ||
"Count": 1, | ||
"Timeout": "PT10M" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we renaming properties in a file called non-existent-policy-attribute.json
away from a nonexistent name to a recognized name? This looks like it's removing a test for a specific behavior.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
We are using
this
to refer to static methods, which fails at runtime. Use the class name instead.Fixes #32454.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license