Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 1.23 documentation #1101

Open
zyberon opened this issue Dec 11, 2024 · 1 comment
Open

Improve 1.23 documentation #1101

zyberon opened this issue Dec 11, 2024 · 1 comment
Assignees

Comments

@zyberon
Copy link

zyberon commented Dec 11, 2024

Hello I have just downloaded the new version, but I'm not sure if the documentation is updated to the new feature, how this works with the ASG to cordon and drain the nodes before shutting down, does the new nodes wait for the old ones to being deleted? and it is getting the events through the metadata?

Also is this tool making the nodes drain gracefully and one by one? what i mean is that when the asg send the termination event is the tool prepared to manage that events as a queue and proceed to drain a node, add the new not ready node to the cluster, and then proceed with draining the other node.

Thank you so much in advance.

@Lu-David Lu-David self-assigned this Dec 17, 2024
@Lu-David
Copy link
Contributor

Lu-David commented Jan 13, 2025

Hi @zyberon,

Will update the docs to be clearer but to answer your question:

how this works with the ASG to cordon and drain the nodes before shutting down, does the new nodes wait for the old ones to being deleted? and it is getting the events through the metadata?

  1. Yes ASG Lifecycle state support is getting events through instance metadata.

Also is this tool making the nodes drain gracefully and one by one? what i mean is that when the asg send the termination event is the tool prepared to manage that events as a queue and proceed to drain a node, add the new not ready node to the cluster, and then proceed with draining the other node.

  1. It depends which mode of NTH you are using.

There is no queue if you are using IMDS mode. Each node listens to this endpoint : /latest/meta-data/autoscaling/target-lifecycle-state according to the docs. Whenever the node will soon be entering the Terminated State, NTH will then cordon and drain. So each node is draining asynchronously.

However, if you want to use ASG Lifecycle with Queue Processor, then yes the nodes would get cordoned and drained one by one

Hope this helps! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants