-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] SQS mode: prometheus add nodes gauge #1083
base: main
Are you sure you want to change the base?
Conversation
6e910d0
to
91e34ac
Compare
@stevehipwell can you please give me a help on this. Now i only stuck at writing unit test for Do you think i should refactor this file along with this PR or should I open another separate PR (eg: make opentelemetry.go testable) |
@phuhung273 I'm not a maintainer here but I like to see untestable code refactored to be testable, following the boy scout rule. If you do the work in this PR you can always split the refactoring to a separate PR before it's merged. @LikithaVemulapalli what do you think? |
Yes I agree with @stevehipwell here, let's separate refactoring PR to have a clear idea on the changes made. @phuhung273 if you want to test your changes for this PR let me know I will approve and run so for the future commits you can verify if the existing tests are working, if there are any conflicts or not, once you change the PR status to ready I will run the workflow, appreciate for your contribution. Thanks! |
Issue #, if available:
#785
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.