Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] SQS mode: prometheus add nodes gauge #1083

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

phuhung273
Copy link

Issue #, if available:
#785

Description of changes:

  • Count nodes being tracked

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phuhung273 phuhung273 requested a review from a team as a code owner October 29, 2024 14:34
@phuhung273 phuhung273 marked this pull request as draft October 29, 2024 14:34
@phuhung273 phuhung273 changed the title [WIP] Prometheus export nodes counter [WIP] IMDS mode: prometheus add nodes counter Nov 1, 2024
@phuhung273 phuhung273 changed the title [WIP] IMDS mode: prometheus add nodes counter [WIP] IMDS mode: prometheus add nodes gauge Nov 1, 2024
@phuhung273 phuhung273 changed the title [WIP] IMDS mode: prometheus add nodes gauge [WIP] SQS mode: prometheus add nodes gauge Nov 11, 2024
@phuhung273
Copy link
Author

@stevehipwell can you please give me a help on this. Now i only stuck at writing unit test for opentelemetry.go since it doesn
t have any test.

Do you think i should refactor this file along with this PR or should I open another separate PR (eg: make opentelemetry.go testable)

@stevehipwell
Copy link
Contributor

@phuhung273 I'm not a maintainer here but I like to see untestable code refactored to be testable, following the boy scout rule. If you do the work in this PR you can always split the refactoring to a separate PR before it's merged.

@LikithaVemulapalli what do you think?

@LikithaVemulapalli
Copy link
Contributor

Yes I agree with @stevehipwell here, let's separate refactoring PR to have a clear idea on the changes made. @phuhung273 if you want to test your changes for this PR let me know I will approve and run so for the future commits you can verify if the existing tests are working, if there are any conflicts or not, once you change the PR status to ready I will run the workflow, appreciate for your contribution. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants