Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prometheus port (#1078) and add unit test for opentelemetry (#1088) #1093

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tiationg-kho
Copy link

Fix prometheus port (#1078) and add unit test for opentelemetry (#1088)

**Issue #, if available:
#1078
#1088

Description of changes:

  • When enablePrometheusServer config is false, we will not open the port
  • Add unit test for pkg/observability/opentelemetry.go file

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tiationg-kho tiationg-kho requested a review from a team as a code owner November 28, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant