fix: Force strings to be outputted when string starts with 0 #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriram-mv
requested changes
May 6, 2020
| TAG_STR = "tag:yaml.org,2002:str" | ||
|
|
||
|
|
||
| def string_representer(dumper, value): |
There was a problem hiding this comment.
could you add a docstring here, just to explain what happens here.
There was a problem hiding this comment.
Good Callout, I meant to go back and completely forgot. Will get a new revision with that here soon.
sriram-mv
approved these changes
May 7, 2020
6 tasks
c2tarun
added a commit
that referenced
this pull request
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#867
Why is this change necessary?
When build outputs a template, the yaml dumper will omit the quotes when the number could not parse as a valid octal number. This will then lead to CFN stripping the 0 off the string (mostly accountids) and cause CFN stacks to fail.
How does it address the issue?
We will force the yaml dumper to output a string if there is a scalar with that starts with 0.
What side effects does this change have?
None that I know of
Did you change a dependency in
requirements/base.txt?If so, did you run
make update-reproducible-reqsN/A
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.