Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump urllib3 from 1.26.19 to 2.2.3 in /requirements #7475

Merged
merged 5 commits into from
Sep 27, 2024
Merged

chore(deps): bump urllib3 from 1.26.19 to 2.2.3 in /requirements #7475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4be41b5
chore(deps): bump urllib3 from 1.26.19 to 2.2.3 in /requirements
dependabot[bot] Sep 13, 2024
05b7ae7
Update reproducibles: update-reproducible-mac-reqs
actions-user Sep 13, 2024
2b37fdc
Merge branch 'develop' into dependabot/pip/requirements/develop/urlli…
sidhujus Sep 20, 2024
3a1e079
Merge branch 'develop' into dependabot/pip/requirements/develop/urlli…
lucashuy Sep 24, 2024
6565ea6
Merge branch 'develop' into dependabot/pip/requirements/develop/urlli…
lucashuy Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions requirements/reproducible-linux.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,9 +983,9 @@ tzlocal==5.2 \
# via
# aws-sam-cli (setup.py)
# dateparser
urllib3==1.26.19 \
--hash=sha256:37a0344459b199fce0e80b0d3569837ec6b6937435c5244e7fd73fa6006830f3 \
--hash=sha256:3e3d753a8618b86d7de333b4223005f68720bcd6a7d2bcb9fbd2229ec7c1e429
urllib3==2.2.3 \
Copy link
Contributor

@hnnasit hnnasit Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we run integ tests against this PR to make sure start-api tests don't break? I recall boto3 also had this version pinned so we might need to validate that as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, let me kick that off. botocore (and by extension boto3) did have this pinned, not entirely sure why Linux was left out of the equation when Windows was updated, but this should be safe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are all good, no tests that talk to the AWS API broke as a result of the upgrade.

--hash=sha256:ca899ca043dcb1bafa3e262d73aa25c465bfb49e0bd9dd5d59f1d0acba2f8fac \
--hash=sha256:e7d814a81dad81e6caf2ec9fdedb284ecc9c73076b62654547cc64ccdcae26e9
# via
# botocore
# docker
Expand Down
6 changes: 3 additions & 3 deletions requirements/reproducible-mac.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,9 +1018,9 @@ tzlocal==5.2 \
# via
# aws-sam-cli (setup.py)
# dateparser
urllib3==1.26.19 \
--hash=sha256:37a0344459b199fce0e80b0d3569837ec6b6937435c5244e7fd73fa6006830f3 \
--hash=sha256:3e3d753a8618b86d7de333b4223005f68720bcd6a7d2bcb9fbd2229ec7c1e429
urllib3==1.26.20 \
--hash=sha256:0ed14ccfbf1c30a9072c7ca157e4319b70d65f623e91e7b32fadb2853431016e \
--hash=sha256:40c2dc0c681e47eb8f90e7e27bf6ff7df2e677421fd46756da1161c39ca70d32
# via
# botocore
# docker
Expand Down
6 changes: 3 additions & 3 deletions requirements/reproducible-win.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,9 +992,9 @@ tzlocal==5.2 \
# via
# aws-sam-cli (setup.py)
# dateparser
urllib3==2.2.2 \
--hash=sha256:a448b2f64d686155468037e1ace9f2d2199776e17f0a46610480d311f73e3472 \
--hash=sha256:dd505485549a7a552833da5e6063639d0d177c04f23bc3864e41e5dc5f612168
urllib3==2.2.3 \
--hash=sha256:ca899ca043dcb1bafa3e262d73aa25c465bfb49e0bd9dd5d59f1d0acba2f8fac \
--hash=sha256:e7d814a81dad81e6caf2ec9fdedb284ecc9c73076b62654547cc64ccdcae26e9
# via
# botocore
# docker
Expand Down
Loading