Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ConcurrentModificationException at v2-migration #5665

Merged
merged 2 commits into from
Nov 23, 2024
Merged

fix ConcurrentModificationException at v2-migration #5665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30027d3
fix ConcurrentModificationException at v2-migration
sk-br Oct 14, 2024
f633874
Merge branch 'master' into sk-br/fix-migration-recipe
debora-ito Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/next-release/bugfix-v2migrationOpenRewriterecipe-86404ba.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "bugfix",
"category": "v2-migration OpenRewrite recipe",
"contributor": "sk-br",
"description": "This fixes a ConcurrentModificationException - just by replacing a HashMap with ConcurrentHashMap"
}
4 changes: 2 additions & 2 deletions v2-migration/src/main/java/software/amazon/awssdk/v2migration/ChangeSdkType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@
import static software.amazon.awssdk.v2migration.internal.utils.SdkTypeUtils.isV1ModelClass;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.HashSet;
import java.util.IdentityHashMap;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.Stack;
import java.util.concurrent.ConcurrentHashMap;
import org.openrewrite.ExecutionContext;
import org.openrewrite.Recipe;
import org.openrewrite.TreeVisitor;
Expand Down Expand Up @@ -88,7 +88,7 @@ private static class ChangeTypeVisitor extends JavaVisitor<ExecutionContext> {
private final Set<String> topLevelClassnames = new HashSet<>();
private final List<String> wildcardImports = new ArrayList<>();

private Map<String, Pair<JavaType.Class, JavaType>> oldTypeToNewType = new HashMap<>();
private Map<String, Pair<JavaType.Class, JavaType>> oldTypeToNewType = new ConcurrentHashMap<>();

@Override
public J visitClassDeclaration(J.ClassDeclaration classDecl, ExecutionContext ctx) {
Expand Down
Loading