Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 HttpPipeline ReadOnlyMemory #3468

Open
2 tasks done
danielmarbach opened this issue Sep 8, 2024 · 0 comments
Open
2 tasks done

v4 HttpPipeline ReadOnlyMemory #3468

danielmarbach opened this issue Sep 8, 2024 · 0 comments
Assignees
Labels
feature-request A feature should be added or improved. module/sdk-core p2 This is a standard priority issue v4

Comments

@danielmarbach
Copy link
Contributor

Describe the feature

As of today, the HTTP pipeline supports either Content as byte[] or a stream when the ContentStream property is set. I would appreciate it if the http pipeline could handle ReadOnlyMemory<byte> to support better options for buffering.

Technically you could support ROM already by wrapping the ROM in a ReadOnlyStream that uses the ROM behind the scenes but that would require the Content property to be deprecated and phased out. If the Content property is switched to ROM it probably would also require quite a few changes to the SDK to properly adjust the generator to handle it as well as introducing necessary overloads on the methods that are used to pass in the byte array content. All in all that is too much work to handle as a community contribution and that is why I wanted to open up the discussion whether the team has already ideas how and when they will tackle it.

Another option would be to introduce new properties on the request and response interfaces and slowly transition over

Use Case

More efficient memory handling in the Core of the SDK

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

v4

Targeted .NET Platform

All

Operating System and version

All

@danielmarbach danielmarbach added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 8, 2024
@bhoradc bhoradc added module/sdk-core p2 This is a standard priority issue needs-review v4 and removed needs-triage This issue or PR still needs to be triaged. needs-review labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/sdk-core p2 This is a standard priority issue v4
Projects
None yet
Development

No branches or pull requests

3 participants