feature: add support for per-service endpoint url configuration #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamRemis
reviewed
Aug 3, 2023
SamRemis
reviewed
Aug 3, 2023
added 5 commits
August 8, 2023 12:03
pick 1ca30ba add support for per-service endpoint url configuration
stobrien89
force-pushed
the
endpoint-url-config
branch
from
0f8236a
to
8aa98e0
Compare
added 8 commits
August 8, 2023 12:27
SamRemis
approved these changes
Aug 28, 2023
SamRemis
reviewed
Aug 29, 2023
SamRemis
reviewed
Aug 30, 2023
SamRemis
approved these changes
Aug 31, 2023
added 7 commits
August 31, 2023 18:21
SamRemis
approved these changes
Sep 1, 2023
| @@ -35,6 +36,7 @@ public static function getArguments() | |||
| // (e.g. http://search-blah.{region}.cloudsearch.amazonaws.com) | |||
| return explode('.', new Uri($args['endpoint']))[1]; | |||
| }; | |||
| unset($args['endpoint']['default']); | |||
There was a problem hiding this comment.
Why is this necessary? This seems like an endpoint is always required, so it should never go to the default?
There was a problem hiding this comment.
The client resolver won't handle the 'required' property if there's a default
SamRemis
pushed a commit
to SamRemis/aws-sdk-php
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1239
Description of changes:
Adds the ability to configure endpoints on a per-service basis via the environment and ini file. Order of precedence is as follows:
endpointclient configurationAWS_ENDPOINT_URL_<SERVICE_IDENTIFIER>env varservicesendpoint in shared config example:AWS_ENDPOINT_URLenv varendpoint_urlin shared config. example:For backward-compatibility, we will continue to support the
endpointclient constructor option, however,endpoint_urlwill take precedence, if resolved from any one of the above-mentioned options.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.