Prisma sdk contrib #532
Open
Prisma sdk contrib #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
==========================================
+ Coverage 83.41% 83.49% +0.07%
==========================================
Files 37 37
Lines 1797 1805 +8
==========================================
+ Hits 1499 1507 +8
Misses 298 298 ☔ View full report in Codecov by Sentry. |
|
@EduardMcfly thanks for addressing the previous feedback! Can you please take a look at the failing workflows? |
This commit adds a new package dependency for integrating AWS X-Ray with Prisma. Specifically, it adds the package "aws-xray-sdk-prisma" and sets its version to 3.5.0 in the package-lock.json file. Additionally, in the "capturePrisma" function in the "sdk_contrib/prisma/src/capturePrisma.ts" file, an error message is logged if no segment is provided in manual mode. In the unit tests for the "capturePrisma" function in the "sdk_contrib/prisma/test/unit/prisma.test.js" file, the Prisma client is now initialized with a segment, and the absence of a segment is properly handled and logged as an error. These changes ensure proper integration of AWS X-Ray with Prisma and improve error handling when manual mode is used without a segment.
* bumped typescript version * fixed ts errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add X-Ray plugin for Prisma
Add typing, unit tests, examples with automatic mode and manual mode
The package was published in @cosva-lab/aws-xray-sdk-prisma and its correct operation was verified.
Example timeline
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.