[Bug]: Sample session is closed on master side after viewer disconnection

[skndi]

Please confirm you have already done the following

• I have searched the repository for related/existing bug reports
• I have all the details the issue requires

Describe the bug

When a viewer disconnection is detected the stream is closed immediately instead of waiting for a reconnection.

Expected Behavior

The session should not be destructed before ICE_CONNECTION_STATE_FAILED is reached.

Current Behavior

https://gist.github.com/skndi/95bb6a5548905fecd0de9ea7745e0742

The behavior seems to come from this line

amazon-kinesis-video-streams-webrtc-sdk-c/samples/Common.c

Line 84 in 8248241

ATOMIC_STORE_BOOL(&pSampleStreamingSession->terminateFlag, TRUE);

I think the session should be marked for termination only if the new state is RTC_PEER_CONNECTION_STATE_FAILED or RTC_PEER_CONNECTION_STATE_FAILED.

Reproduction Steps

1. Start a session between master/viewer
2. Prevent the viewer from sending heartbeat messages, e.g. stop internet connection on viewer side
3. Observe the session is closed immediately when disconnection is sensed

WebRTC C SDK version being used

1.10.2

Compiler and Version used

gcc 10.2

Operating System and version

Embedded Linux

Platform being used

Ambarella CV2 chip, aarch64

[stefankiesz]

Hi @skndi, than you for pointing this out. I will consider this change in sample behavior.