Event Loop & Socket Type Multi-Support #692
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #692 +/- ##
==========================================
- Coverage 80.08% 79.66% -0.43%
==========================================
Files 29 30 +1
Lines 6001 6122 +121
==========================================
+ Hits 4806 4877 +71
- Misses 1195 1245 +50 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
xiazhvera
changed the title
… runtime_select_event_loop
Co-authored-by: Michael Graeb <[email protected]>
| @@ -172,6 +192,8 @@ struct aws_event_loop *aws_event_loop_new_default(struct aws_allocator *alloc, a | |||
| /** | |||
| * Creates an instance of the default event loop implementation for the current architecture and operating system using | |||
| * extendable options. | |||
| * | |||
| * Please note the event loop type defined in the options will be ignored. | |||
| */ | |||
| AWS_IO_API | |||
| struct aws_event_loop *aws_event_loop_new_default_with_options( | |||
There was a problem hiding this comment.
Can we just eliminate all these alternate constructors and replace them with a single aws_event_loop_new(allocator, options)?
I mean ... they were already in a private header
or is that going to happen in some future PR?
There was a problem hiding this comment.
I eventually keep two constructors: aws_event_loop_new_default and aws_event_loop_new. aws_event_loop_new_default was used cross the aws-c-io tests to create default event loop. If we remove it, we probably need create help functions in all those test files, therefore I leave it there...
| AWS_ASSERT(false && "Invalid socket implementation on platform."); | ||
| return aws_socket_init_apple_nw_socket(socket, alloc, options); |
There was a problem hiding this comment.
why is this assert(false) here?
There was a problem hiding this comment.
At the point of this PR, apple network framework is not supported yet. Added the assertion to warn developer that we should never use this type so far.
I will update the comments to explan it.
…io into runtime_select_event_loop
…io into runtime_select_event_loop
| * default. | ||
| * | ||
| * Default Event Loop Type | ||
| * Linux | AWS_EVENT_LOOP_EPOLL |
There was a problem hiding this comment.
Table isn't very well aligned
| * `AWS_SOCKET_IMPL_PLATFORM_DEFAULT`, it will automatically use the platform’s default. | ||
| * | ||
| * PLATFORM DEFAULT SOCKET IMPLEMENTATION TYPE | ||
| * Linux | AWS_SOCKET_IMPL_POSIX |
| @@ -131,7 +131,8 @@ struct aws_event_loop_vtable s_kqueue_vtable = { | |||
| .is_on_callers_thread = s_is_event_thread, | |||
| }; | |||
|
|
|||
| struct aws_event_loop *aws_event_loop_new_default_with_options( | |||
| #ifdef AWS_ENABLE_KQUEUE | |||
There was a problem hiding this comment.
How would we be here if this wasn't defined?
There was a problem hiding this comment.
If not defined AWS_ENABLE_KQUEUE, the following function should be defined. (in source/event_loop.c)
#ifndef AWS_ENABLE_KQUEUE
struct aws_event_loop *aws_event_loop_new_with_kqueue(
struct aws_allocator *alloc,
const struct aws_event_loop_options *options) {
(void)alloc;
(void)options;
AWS_ASSERT(0);
AWS_LOGF_DEBUG(AWS_LS_IO_EVENT_LOOP, "Kqueue is not supported on the platform");
aws_raise_error(AWS_ERROR_PLATFORM_NOT_SUPPORTED);
return NULL;
}
#endif // AWS_ENABLE_EPOLL
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.