Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the Options for storing the sensitive parameters to include binaray secrets and SSM Parameter Store #180

Open
ChrisPates opened this issue Mar 21, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ChrisPates
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently sensitive configuration data must be stored in AWS Secrets Manager secrets, however for some customers using SSM Parameter Store may be sufficient (since they do not need cross account/cross region support) and wish to reduce the operating cost of the SSOSync deployment.

Describe the solution you'd like
Add detection for and support of SSM parameter store secrets and binary secrets in Secrets Manager.

Additional context
Requests originally raised under the following issues:

@dancorne
Copy link

Hey @ChrisPates, I'd opened #130 because it looked like binary secrets should work, however I believe the logic is buggy there. It was easy enough for us to switch to a string secret to fix our syncing, but also the bugfix is fairly trivial so thought I'd open a PR. If you've got wider refactoring plans for this code this might not be needed though, happy to close that PR off if so.

@ChrisPates
Copy link
Contributor Author

ChrisPates commented Mar 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants