Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support XDG_CONFIG_HOME for receipts #171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mistydemeo
Copy link
Contributor

refs axodotdev/cargo-dist#1355.

We'll need to make sure we ship the cargo-dist side as well when shipping this, so we don't get a mismatch in expectations.

An open question on this and the other PR: is it appropriate for us to respect this on both Linux and Mac? I'm assuming yes.

cc @brennanfee

Copy link
Contributor

@Gankra Gankra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this isn't quite right

  • if we see XDG_CONFIG_HOME in env we should always check it regardless of platform
  • we need to try to load a receipt from every valid location for the platform, using the first successful one

@mistydemeo mistydemeo force-pushed the respect_xdg_config_home branch from 698cb92 to 4dbc6bb Compare October 9, 2024 17:46
@mistydemeo mistydemeo force-pushed the respect_xdg_config_home branch from 4dbc6bb to a21ae0a Compare October 9, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants