Add patches to installer to support transition from cargo-home to flat install layouts
#1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested similar patches in production for uv, but these changes are not tested yet. |
zanieb
force-pushed
the
zb/installer-layout
branch
2 times, most recently
from
845334d to
d36f809
Compare
…flat` install layouts
zanieb
force-pushed
the
zb/installer-layout
branch
from
d36f809 to
0af46c1
Compare
ashleygwilliams
approved these changes
Nov 8, 2024
zanieb
added a commit
to astral-sh/ruff
that referenced
this pull request
Nov 19, 2024
Needed to prevent updater failures when doing #13927 See - axodotdev/axoupdater#210 - axodotdev/cargo-dist#1538 - astral-sh/uv#8958
AlexWaygood
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Nov 19, 2024
Needed to prevent updater failures when doing #13927 See - axodotdev/axoupdater#210 - axodotdev/cargo-dist#1538 - astral-sh/uv#8958
MichaReiser
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Nov 20, 2024
Needed to prevent updater failures when doing #13927 See - axodotdev/axoupdater#210 - axodotdev/cargo-dist#1538 - astral-sh/uv#8958
MichaReiser
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Nov 20, 2024
Needed to prevent updater failures when doing #13927 See - axodotdev/axoupdater#210 - axodotdev/cargo-dist#1538 - astral-sh/uv#8958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds patches to the installer to address axodotdev/axoupdater#210 — these patches are more robust versions of the patches described in that issue.
It's important to have a compatibility shim like this at the installer level because the
axoupdatercannot be fixed for previous versions of uv.Arguably, this is pretty specific to us since nobody else has switched layouts and complained that updates were broken. If there's a reasonable way for us to insert the patches on our end, that's fine with me too.Even if anaxoupdaterfix is released soon, this change will be relevant to users upgrading from older versions of an application to the latest version.