Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick from #1298 #1299

Merged
merged 3 commits into from
Feb 1, 2025
Merged

Cherry pick from #1298 #1299

merged 3 commits into from
Feb 1, 2025

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Feb 1, 2025

Also adds partial term in prim, related to #1029

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.46%. Comparing base (f7e1471) to head (85cd353).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...e/src/main/java/org/aya/primitive/PrimFactory.java 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1299      +/-   ##
============================================
+ Coverage     83.44%   83.46%   +0.01%     
- Complexity     4260     4262       +2     
============================================
  Files           388      388              
  Lines         12345    12353       +8     
  Branches       1429     1429              
============================================
+ Hits          10301    10310       +9     
  Misses         1290     1290              
+ Partials        754      753       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000 ice1000 marked this pull request as ready for review February 1, 2025 01:18
@ice1000 ice1000 added this to the v0.38 milestone Feb 1, 2025
@ice1000 ice1000 merged commit 0727d12 into main Feb 1, 2025
6 checks passed
@ice1000 ice1000 deleted the ice1000 branch February 1, 2025 01:22
@ice1000 ice1000 linked an issue Feb 1, 2025 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Re)implement partial elements
1 participant