function to massive setDisplay

[juanmartin84]

Hello, I'm trying to create a function to show/hide some cards according to the value of a variable

I wrote the following, but it doesnt work

void setOutput(String outputType, Card zone, Card zoneSlave, Card zoneAux, Card buttonZone, Card buttonZoneAux){
    if(outputType == "0"){//disable
      zoneCard.setDisplay(false);
      zoneSlaveCard.setDisplay(false);
      zoneAuxCard.setDisplay(false);
      buttonZone.setDisplay(false);
      buttonZoneAux.setDisplay(false);
      }
    if(outputType == "1"){//master
      zoneCard.setDisplay(true);
      zoneSlaveCard.setDisplay(false);
      zoneAuxCard.setDisplay(false);
      buttonZone.setDisplay(true);
      buttonZoneAux.setDisplay(false);
      }
    if(outputType == "2"){//slave
      zoneCard.setDisplay(false);
      zoneSlaveCard.setDisplay(true);
      zoneAuxCard.setDisplay(false);
      buttonZone.setDisplay(false);
      buttonZoneAux.setDisplay(false);
      }
    if(outputType == "3"){//aux
       zoneCard.setDisplay(false);
       zoneSlaveCard.setDisplay(false);
       zoneAuxCard.setDisplay(true);
       buttonZone.setDisplay(false);
       buttonZoneAux.setDisplay(true);
      }
}  

Is there some way to make a kind of function to avoid repeat all this lines for each card?

BR

[mathieucarbou]

your function definition is wrong: you are passing the cards by value. Use ref or pointers. Example:

void setOutput(const String& outputType, Card& zone, Card& zoneSlave, Card& zoneAux, Card& buttonZone, Card& buttonZoneAux){

Also, what you wan to do is better served using switch/case since conditions are mutually exclusive.

switch(outputType.toInt()) {
    case 0: {
        /// setDisplay(...)
        break;
    }
     case 1: {
        /// setDisplay(...)
        break;
    }
    default:
        break;
}

[juanmartin84]

Thanks @mathieucarbou !!!
This made the code much more readable and shorter.
Following with this, is there some way to do something like this with callback functions?

[mathieucarbou]

No because the callback does not hold the information about the card, but what you can do is call the same function.

[juanmartin84]

thanks @mathieucarbou