Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Global Footer with new Twitter Icon #2800

Closed
trackleft opened this issue Oct 6, 2023 · 3 comments · Fixed by #3056
Closed

Update Global Footer with new Twitter Icon #2800

trackleft opened this issue Oct 6, 2023 · 3 comments · Fixed by #3056
Assignees
@mrbeiley
Labels
backport Changes to be back-ported to previous minor release branch patch release Issues to be included in the next patch release task Work that doesn't always require a pull request. visual change Introduces a visual change

Comments

@trackleft
Copy link
Member

trackleft commented Oct 6, 2023 •
edited
Loading

Twitter updated their icon, az-digital/az-icons#38

Need to update demo content with new icon class .az-icon-x-twitter

https://github.com/az-digital/az_quickstart/blob/main/modules/custom/az_global_footer/data/az_global_footer.json#L393-L406

Create a database update to change the class for existing sites similar to this one
https://github.com/az-digital/az_quickstart/blob/main/modules/custom/az_global_footer/az_global_footer.install#L48-L79

Shouldn't need to update the library, since it is using the CDN and is using the main branch.
https://github.com/az-digital/az_quickstart/blob/main/themes/custom/az_barrio/includes/common.inc#L11
@trackleft trackleft added task Work that doesn't always require a pull request. backport Changes to be back-ported to previous minor release branch patch release Issues to be included in the next patch release visual change Introduces a visual change labels Oct 6, 2023
@mrbeiley mrbeiley self-assigned this Oct 13, 2023
@mrbeiley mrbeiley moved this to In Progress in 2.8.x Patch Release Issues Oct 13, 2023
@mrbeiley
Copy link
Contributor

After updating the demo content and updating the database, how do I test?

https://github.com/az-digital/az_quickstart/tree/issues/2800-x-twitter-updates

@akslay
Copy link
Contributor

akslay commented Jan 3, 2024

After creating a pull request, a test build will be automatically created for you on Probo. You should be able to just use that build to visually check that the footer is using your updated icon.

@mrbeiley mrbeiley mentioned this issue Jan 4, 2024
Merged
31 tasks
@trackleft
Copy link
Member Author

trackleft commented Jan 8, 2024 •
edited
Loading

This is blocked by a release v1.0.1 of https://github.com/az-digital/az-icons or az-digital/az-icons#22 or updating the included icon library in az_quickstart https://github.com/az-digital/az_quickstart/tree/main/themes/custom/az_barrio/libraries/az-icons

az_barrio references the main bucket in the CDN https://cdn.digital.arizona.edu/lib/az-icons/main/az-icons-styles.css.

@trackleft trackleft linked a pull request Jan 9, 2024 that will close this issue
Close #2800 Update Global Footer with new X/Twitter Icon. #3056
Merged
31 tasks
@joeparsons joeparsons moved this from Todo to Needs review in 2.9.0-beta1 pre-release Jan 9, 2024
@joeparsons joeparsons moved this to Needs review in 2.8.x Patch Release Issues Jan 9, 2024
@danahertzberg danahertzberg moved this from Needs review to In Progress in 2.9.0-beta1 pre-release Jan 10, 2024
trackleft added a commit that referenced this issue Jan 10, 2024
@mrbeiley @joeparsons
@bberndt-uaz @trackleft @danahertzberg
Close #2800 Update Global Footer with new X/Twitter Icon. (#3056)
de2c2cf 
Co-authored-by: Joe Parsons <[email protected]>
Co-authored-by: bberndt-uaz <[email protected]>
Co-authored-by: Chris Green <[email protected]>
Co-authored-by: Dana Hertzberg <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in 2.9.0-beta1 pre-release Jan 10, 2024
trackleft added a commit that referenced this issue Jan 10, 2024
@mrbeiley @joeparsons
@bberndt-uaz @trackleft @danahertzberg
Close #2800 Update Global Footer with new X/Twitter Icon. (#3056)
b40c83d 
Co-authored-by: Joe Parsons <[email protected]>
Co-authored-by: bberndt-uaz <[email protected]>
Co-authored-by: Chris Green <[email protected]>
Co-authored-by: Dana Hertzberg <[email protected]>
@joeparsons joeparsons moved this from Todo to Done in 2.8.4 Patch Release Jan 11, 2024
joeparsons added a commit that referenced this issue Jan 17, 2024
@mrbeiley @joeparsons
@bberndt-uaz @trackleft @danahertzberg
Close #2800 Update Global Footer with new X/Twitter Icon. (#3056)
4dbeba3 
Co-authored-by: Joe Parsons <[email protected]>
Co-authored-by: bberndt-uaz <[email protected]>
Co-authored-by: Chris Green <[email protected]>
Co-authored-by: Dana Hertzberg <[email protected]>
akslay pushed a commit that referenced this issue Jan 19, 2024
@mrbeiley @joeparsons
@bberndt-uaz @trackleft @danahertzberg @akslay
Close #2800 Update Global Footer with new X/Twitter Icon. (#3056)
cf4c98d 
Co-authored-by: Joe Parsons <[email protected]>
Co-authored-by: bberndt-uaz <[email protected]>
Co-authored-by: Chris Green <[email protected]>
Co-authored-by: Dana Hertzberg <[email protected]>
@joeparsons joeparsons mentioned this issue Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrbeiley mrbeiley

Labels
backport Changes to be back-ported to previous minor release branch patch release Issues to be included in the next patch release task Work that doesn't always require a pull request. visual change Introduces a visual change
Projects
No open projects
2.8.4 Patch Release
Status: Done
2.9.0 Minor Release
Status: Done
2.9.0-beta1 pre-release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close #2800 Update Global Footer with new X/Twitter Icon. az-digital/az_quickstart
3 participants
@trackleft @mrbeiley @akslay