Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3997 Adjust default Chosen width #4060

Merged
merged 7 commits into from
Feb 14, 2025
Merged

Closes #3997 Adjust default Chosen width #4060

merged 7 commits into from
Feb 14, 2025

Conversation

joshuasosa
Copy link
Contributor

Description

Adjusts the default width setting in Chosen and adds admin-specific style overrides.

Related issues

Closes #3997

How to test

Visit a page with Chosen enabled to see the selector and dropdown box sizing.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@joshuasosa joshuasosa marked this pull request as ready for review February 11, 2025 01:02
@joshuasosa joshuasosa requested a review from a team as a code owner February 11, 2025 01:02
mrbeiley
mrbeiley previously approved these changes Feb 11, 2025
Copy link
Contributor

@mrbeiley mrbeiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my local copy.

@joeparsons joeparsons changed the title Adjust default Chosen width Closes #3997 Adjust default Chosen width Feb 11, 2025
@joeparsons joeparsons added bug Something isn't working editor experience Improvements to the editor experience for individuals editing Quickstart websites labels Feb 11, 2025
bberndt-uaz
bberndt-uaz previously approved these changes Feb 11, 2025
Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the improvement to all our paragraph-specific dropdowns:

Before

image

After

image

@joshuasosa joshuasosa dismissed stale reviews from bberndt-uaz and mrbeiley via c76230e February 11, 2025 23:52
bberndt-uaz
bberndt-uaz previously approved these changes Feb 12, 2025
bberndt-uaz
bberndt-uaz previously approved these changes Feb 13, 2025
@trackleft
Copy link
Member

Is this related?
image

joeparsons
joeparsons previously approved these changes Feb 13, 2025
Copy link
Member

@joeparsons joeparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bberndt-uaz bberndt-uaz dismissed their stale review February 13, 2025 22:01

Requesting fix for search input issue

Copy link
Member

@trackleft trackleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement, thanks!

@joeparsons joeparsons merged commit cf7997a into main Feb 14, 2025
15 of 16 checks passed
@joeparsons joeparsons deleted the issue/3997 branch February 14, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor experience Improvements to the editor experience for individuals editing Quickstart websites
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Adjust default Chosen width
5 participants