Exception handling for DB failure #20457
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CORE
| } catch (const std::exception& ex) { | ||
| LOG_ERROR("server.authserver", "Database initialization failed: {}", ex.what()); | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
hello and thanks for your contribution! can you please fix the code indentation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is aimed at exception handling for the DB initialization process within the server's authentication module. By wrapping the
StartDB()function in a try-catch block, this change ensures that any exceptions thrown during DB startup are properly caught and logged, preventing the server from failing silently if the database connection cannot be established. Specifically, it logs an error message and exits with code 1 if the initialization fails.The change has been tested by me in a controlled dev env to ensure the exception handling works as expected.
I hope you find this tiny change useful ! I apologize if it is not (I am mostly a full stack web dev!)
Good luck !