Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags issue #44

Open
cccccmake opened this issue Nov 8, 2021 · 0 comments
Open

Tags issue #44

cccccmake opened this issue Nov 8, 2021 · 0 comments

Comments

@cccccmake
Copy link

Hello dear guys!

In file layouts/posts/summary.html, line 14, <a href="{{ $baseurl }}{{ $.Site.LanguagePrefix }}/tags/{{ . }}">{{ . }}</a>, I think it should be <a href="{{ $baseurl }}{{ $.Site.LanguagePrefix }}/tags/{{ . | lower}}/">{{ . }}</a> when considering some tags may start with alphabet which is in uppercase. Besides, it should have a / at the end inside the href label, otherwise it cannot jump from the tags which locate in summary page.

The same issue occurs in file layout/posts/single.html, line 20, <a href="{{ $baseurl }}{{ $.Site.LanguagePrefix }}/tags/{{ . }}">{{ . }}</a>, which should be <a href="{{ $baseurl }}{{ $.Site.LanguagePrefix }}/tags/{{ . | lower}}/">{{ . }}</a>.

I hope this doesn't bother you:) but the problems really occurs to me and after rewriting these 2 lines it works fine.

(btw.I really love this theme ❤️)

Sincerely,
Jiabin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant