Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

GEO related commands #66

Closed
SharksT opened this issue Sep 27, 2019 · 10 comments
Closed

GEO related commands #66

SharksT opened this issue Sep 27, 2019 · 10 comments

Comments

@SharksT
Copy link

SharksT commented Sep 27, 2019

Hello, I can see that there is not GEO related commands implemented, such as GEOADD, GEODIST and so on.

I need those to my use-case, can you help? It is hard to implement?

@aembke
Copy link
Contributor

aembke commented Sep 28, 2019

Those should be pretty quick to implement. I was planning on working on this a bit this weekend and I'll add those as well.

@SharksT
Copy link
Author

SharksT commented Sep 28, 2019

Awesome !

@SharksT
Copy link
Author

SharksT commented Oct 4, 2019

Hi, did you manage to do it ?, i can see that you have implemented it on feature/lua, but did you finish it ?

@aembke
Copy link
Contributor

aembke commented Oct 4, 2019

Yeah it's partially implemented on that branch, but I haven't had a chance to fully finish it or add tests yet. I'm planning on finishing it this weekend though. We use this at work in production so the review/test process might take another day or two, but it should be ready this weekend or early next week.

@SharksT
Copy link
Author

SharksT commented Oct 15, 2019

Any news?

@alecembke-okta
Copy link
Contributor

hey @SharksT sorry for the delay. I have this almost entirely implemented, but it turns out the georadius commands require breaking changes to the public interface for types. I'm working on trying to do that as easily as possible, but it will likely take a bit more time.

@SharksT
Copy link
Author

SharksT commented Oct 29, 2019

I'm using fred in my project that is going to release its MVP soon, do you think that it can be done in less than a month?,

@aembke
Copy link
Contributor

aembke commented Oct 29, 2019

yeah it'll be done by then, most likely early next week

@alecembke-okta
Copy link
Contributor

@SharksT this will go up in v1.3.0 in this PR #69 if you want to track it

@alecembke-okta
Copy link
Contributor

@SharksT just a heads up - this repository is moving to a new location here. the crates.io location will not change, so you don't need to change anything in your toml if you're using that. i'll put a notice up in the README here sometime soon as well.

the new version (3.0.0) is a complete rewrite on async/await, new tokio, etc, and supports the GEO interface.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants