-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last merges contained some bad changes #6
Comments
@LXBdev : First issue can be handled in the next check in. Regarding the second issue, could you please make sure that, you have the reply url "https://b2capi.com" is present under native platform in your app registration ? (Step number 5 in read me) I understand that, previous worked for you, but there is no change in the code as such which could effect the effect the redirect uri. ADAL implementation MSAL implementation _app = PublicClientApplicationBuilder.Create(Properties.Settings.Default.V2AppId) |
@PramodKumarHK89 |
@LXBdev : I tried the app with new registration however, I could not reproduce either. I have created PR by removing the msal cache from bin folder. That should address the first issue. |
Related to "removing the msal cache from bin folder" - in general .NET projects have a standard .gitignore that excludes all nested obj & bin folders that contain build output and also the .vs folder that can contain private stuff. I suggest you consider creating a blank C# project in Visual Studio and copy its .gitignore. Also you have directly bundled Newtonsoft.Json as a binary instead of referencing it using NuGet. If I can find time I'll submit a PR... |
Just some quick notes because I just pulled the last version and was unable to use it. Going back to an earlier one for now, may take a look at the issues later.
B2CPolicyManager.exe.msalcache.bin
must not be checked in for the bin folder, it is a system local file and the app will crash on other systems on login@PramodKumarHK89 fyi
The text was updated successfully, but these errors were encountered: