From 8e0c366627b414b8d7502d6ad016ace0e36c3ba6 Mon Sep 17 00:00:00 2001 From: Tim Date: Fri, 9 Aug 2024 01:30:28 +0200 Subject: [PATCH 1/3] initial commit --- src/dom/node.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/dom/node.ts b/src/dom/node.ts index 258378f..e78e358 100644 --- a/src/dom/node.ts +++ b/src/dom/node.ts @@ -635,6 +635,9 @@ export class Text extends CharacterData { get textContent(): string { return this.nodeValue; } + set textContent(value) { + this.nodeValue = value; + } } export class Comment extends CharacterData { From 9df2d08ad04938558ca7b4e89142820d6edf6c52 Mon Sep 17 00:00:00 2001 From: Tim Date: Fri, 9 Aug 2024 10:31:23 +0200 Subject: [PATCH 2/3] add text --- test/units/CharacterData.ts | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/test/units/CharacterData.ts b/test/units/CharacterData.ts index bccb4ce..be30104 100644 --- a/test/units/CharacterData.ts +++ b/test/units/CharacterData.ts @@ -128,3 +128,14 @@ Deno.test("CharacterData.after/before/remove/replaceWith", () => { assertEquals(comment.previousSibling, null); assertEquals(comment.nextSibling, null); }); + +Deno.test("CharacterData.textContent", () => { + const doc = new DOMParser().parseFromString( + `foo`, + "text/html", + ); + const text = doc.body.childNodes[0]; + assertEquals(text.textContent, "foo"); + text.textContent = "bar"; + assertEquals(text.textContent, "bar"); +}); From 71617e273e4616f608336a45389c693cc39ed0c4 Mon Sep 17 00:00:00 2001 From: Tim Date: Fri, 9 Aug 2024 10:35:57 +0200 Subject: [PATCH 3/3] remove getter/setter --- src/dom/node.ts | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/dom/node.ts b/src/dom/node.ts index e78e358..64b2456 100644 --- a/src/dom/node.ts +++ b/src/dom/node.ts @@ -631,13 +631,6 @@ export class Text extends CharacterData { _shallowClone(): Node { return new Text(this.textContent); } - - get textContent(): string { - return this.nodeValue; - } - set textContent(value) { - this.nodeValue = value; - } } export class Comment extends CharacterData {