Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unbonding state transitions #27
feat: unbonding state transitions #27
Changes from 9 commits
b5fa82b
3e45e15
03891d7
9ccb345
35f1e5d
8e7e0b1
bc529cd
b649dc6
8d3ee72
2d25c1b
ecc2b8e
12ccb48
132d6bd
0d73e74
2bf39e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we have a method in the utils to map the BBN state into web state? i.e
types.DelegationState(unbondedEarlyEvent.NewState)
seems ok to me, but not sure why it's removed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the state sent in Babylon event is
Unbonded
, types.DelegationState(unbondedEarlyEvent.NewState) would give usUnbonded
but the indexer needs to treat this as
Unbonding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this validation is too strong which will leads to issues when we have duplicated entries in db upon re-bootstrap of the service.
We have this set of methods in the phase-1 which i think we can re-use in phase-2 https://github.com/babylonlabs-io/staking-api-service/blob/main/internal/shared/utils/state_transition.go#L34
i.e ignore if the state is already beyond the withdrawable state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see, sure i have removed the check.
this might required lot of change in code for the outdated/qualified state transitions, would prefer to do in separate pr
#29
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.