feat(adr-032): Add ResumeFinalityProposal and handler #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
requested review from
KonradStaniec and
Lazar955
and removed request for
a team
Lazar955
reviewed
Nov 1, 2024
x/finality/keeper/gov_test.go
Outdated
| } | ||
|
|
||
| func generateNFpPks(t *testing.T, r *rand.Rand, n int) []bbntypes.BIP340PubKey { | ||
| fpPks := make([]bbntypes.BIP340PubKey, 0) |
There was a problem hiding this comment.
Suggested change
| fpPks := make([]bbntypes.BIP340PubKey, 0) | |
| fpPks := make([]bbntypes.BIP340PubKey, 0, n) |
x/finality/client/cli/gov.go
Outdated
Comment on lines
83
to
90
| fpPks := make([]bbntypes.BIP340PubKey, len(fps.FinalityProviders)) | ||
| for i, pkStr := range fps.FinalityProviders { | ||
| pk, err := bbntypes.NewBIP340PubKeyFromHex(pkStr) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("invalid finality provider public key %s: %w", pkStr, err) | ||
| } | ||
| fpPks[i] = *pk | ||
| } |
There was a problem hiding this comment.
Suggested change
| fpPks := make([]bbntypes.BIP340PubKey, len(fps.FinalityProviders)) | |
| for i, pkStr := range fps.FinalityProviders { | |
| pk, err := bbntypes.NewBIP340PubKeyFromHex(pkStr) | |
| if err != nil { | |
| return nil, fmt.Errorf("invalid finality provider public key %s: %w", pkStr, err) | |
| } | |
| fpPks[i] = *pk | |
| } | |
| fpPks := make([]bbntypes.BIP340PubKey, 0, len(fps.FinalityProviders)) // avoid wrangling indexes | |
| for i, pkStr := range fps.FinalityProviders { | |
| pk, err := bbntypes.NewBIP340PubKeyFromHex(pkStr) | |
| if err != nil { | |
| return nil, fmt.Errorf("invalid finality provider public key %s: %w", pkStr, err) | |
| } | |
| fpPks = append(fpPks, *pk) | |
| } |
x/finality/gov.go
Outdated
| ) | ||
|
|
||
| // NewResumeFinalityProposalHandler is a handler for governance proposal on resume finality. | ||
| func NewResumeFinalityProposalHandler(k keeper.Keeper) govtypesv1.Handler { |
There was a problem hiding this comment.
hmm why usage of the old way of handling proposals ? (which I think is discouraged)
Wouldn't it be better to have separate message on finality provider message server which can be only executed by governance module ? (similar to parameters updates)
gitferry
force-pushed
the
gai/gov-jail-fp
branch
2 times, most recently
from
8b76ab0 to
7213b30
Compare
gitferry
force-pushed
the
gai/gov-jail-fp
branch
from
7213b30 to
fc620e3
Compare
Lazar955
approved these changes
Nov 18, 2024
KonradStaniec
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
ResumeFinalityProposaland implements the handler, which is part of ADR-32. This part is quite independent and the algorithm of choosing finality providers to jail can be implemented in the future