Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(docker)resolve Dockerfile issue & fix CVEs #264

Merged
merged 19 commits into from
Nov 21, 2024
Merged

(docker)resolve Dockerfile issue & fix CVEs #264

merged 19 commits into from
Nov 21, 2024

Conversation

huynaism
Copy link
Contributor

Remaining CVEs :

Lib CVE Current version Fixed version Indirect
CometBFT GHSA-p7mv-53f2-4cwj v0.38.14 v0.38.15
wasmd GHSA-g8w7-7vgg-x7xg 0.52.0 0.53.0
wasmd GHSA-fpgj-cr28-fvpx 0.52.0 0.53.0

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

1 similar comment
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@huynaism huynaism requested a review from a team as a code owner November 13, 2024 06:13
@huynaism huynaism requested review from KonradStaniec and Lazar955 and removed request for a team November 13, 2024 06:13
Lazar955
Lazar955 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@Lazar955 Lazar955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Update the changelog

Lazar955
Lazar955 reviewed Nov 13, 2024
View reviewed changes
.github/workflows/publish.yml Outdated
@@ -5,6 +5,7 @@ on:
branches:
- 'main'
- 'dev'
- 'devops/add-docker-sec'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually not! removed it in b627a67

@huynaism
Copy link
Contributor Author

Nice work! Update the changelog

Thanks! Changelog updated

@huynaism huynaism merged commit 4c70a72 into main Nov 21, 2024
12 checks passed
@huynaism huynaism deleted the devops/add-docker-sec branch November 21, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lazar955 Lazar955 Lazar955 approved these changes

@KonradStaniec KonradStaniec Awaiting requested review from KonradStaniec KonradStaniec is a code owner automatically assigned from babylonlabs-io/core-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huynaism @Lazar955