chore: add testnet upgrade data #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafilxTenfen
commented
Dec 4, 2024
RafilxTenfen
commented
Dec 4, 2024
| // Use staking indexer to generate signet blocks until the most recent | ||
| // block possible prior to the upgrade launch. | ||
| // sid btc-headers 195552 {latestTipBlockHeight} --home ... --output file/to/btc-headers.json | ||
| // script how to generate https://github.com/babylonlabs-io/babylon-deployment/blob/9f39a715e54eedf4842632bbbfbdd353fd16951f/deployments/local/upgrades/write-upgrade-btc-headers.sh#L36 |
There was a problem hiding this comment.
✔️ tested to generate 28k headers and it worked fine 🎉
Close to the date 9 Dec the headers will be generated and inserted
RafilxTenfen
changed the title
RafilxTenfen
requested review from
gitferry and
samricotta
and removed request for
a team
…testnet-upgrade-data
…te the config of btc nety
KonradStaniec
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
In general looks good, there are some followups about particular values.
Lets also wait for 👍 from @babylon-devops team that the parameters and data in upgrade is correct.
| "min_commission_rate": "0.03", | ||
| "delegation_creation_base_gas_fee": 1000, | ||
| "allow_list_expiration_height": 26120, | ||
| "btc_activation_height": 220637 |
There was a problem hiding this comment.
as this are the last parameters in the list and the Babylon node does not have concepts of caps, this will be the params required for all new delegations.
We should decide on those values beforehand and make sure the correct ones are in this file. (can be done in separate pr as this require also some product input)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.