Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seg fault while querying finality activation block height #121

Closed
filippos47 opened this issue Nov 9, 2024 · 1 comment
Closed

Seg fault while querying finality activation block height #121

filippos47 opened this issue Nov 9, 2024 · 1 comment
Assignees

Comments

@filippos47
Copy link
Member

Version: v0.10.0

Relevant log:

2024-11-09T06:53:38.073840Z	debug	the finality-provider has sufficient public randomness, skip committing more	{"pk": "74238a4148f44394d4fe0071c8b8afd84fc3c7f019c745bb6c42dacb46798819", "block_height": 22741, "last_committed_height": 24114}
2024-11-09T06:53:39.592097Z	info	the poller retrieved the block from the consumer chain	{"height": 22741}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x2ede1e2]

goroutine 373 [running]:
github.com/babylonlabs-io/babylon/client/query.(*QueryClient).FinalityParams(0x0?)
	/go/pkg/mod/github.com/babylonlabs-io/[email protected]/client/query/finality.go:77 +0x42
github.com/babylonlabs-io/finality-provider/clientcontroller.(*BabylonController).QueryFinalityActivationBlockHeight(0xc0012c94a0?)
	/go/src/github.com/babylonlabs-io/finality-provider/clientcontroller/babylon.go:392 +0x19
github.com/babylonlabs-io/finality-provider/finality-provider/service.(*FinalityProviderInstance).finalitySigSubmissionLoop(0xc0012c94a0)
	/go/src/github.com/babylonlabs-io/finality-provider/finality-provider/service/fp_instance.go:207 +0xa27
created by github.com/babylonlabs-io/finality-provider/finality-provider/service.(*FinalityProviderInstance).Start in goroutine 254
	/go/src/github.com/babylonlabs-io/finality-provider/finality-provider/service/fp_instance.go:128 +0x72a
gitferry added a commit to babylonlabs-io/babylon that referenced this issue Nov 19, 2024
Root cause of
babylonlabs-io/finality-provider#121. If
response is nil due to error, will cause panic
@gitferry
Copy link
Member

gitferry commented Nov 19, 2024

As the root cause is addressed in #277, the issue will be addressed after bumping the next Babylon version

@gitferry gitferry self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants