Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of backup_migrate_include() entirely #161

Closed
argiepiano opened this issue Apr 2, 2024 · 4 comments · Fixed by #162
Closed

Remove the use of backup_migrate_include() entirely #161

argiepiano opened this issue Apr 2, 2024 · 4 comments · Fixed by #162

Comments

@argiepiano
Copy link
Collaborator

backup_migrate_include() seems to cause some issues in some instances when it appears in update hooks (see #160).

In Drupal 7, this function was completely removed. We should do the same. See https://www.drupal.org/project/backup_migrate/issues/3154166

@izmeez
Copy link

izmeez commented Jun 20, 2024

The drupal issue opening explanation may help in understanding this fix:

With modern PHP there's no need to track which files are loaded, just use include_once() when needed and the rest will be taken care of.

@argiepiano
Copy link
Collaborator Author

@cellear I would like to merge this PR that has been sitting here for 3 months. I've tested without any issues. Let me know if you can test, and I'll wait a bit for you to do so.

@cellear
Copy link
Contributor

cellear commented Jul 12, 2024

Let me see if I can find the time this weekend to make an attempt at that.

@argiepiano
Copy link
Collaborator Author

Thanks! Testing should be simple. There is actually no bug, rather a "task" that was ported from D7. So the idea is to install BAM and patch it on a site, then try to create as many types of backups as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants