Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we remove vertical tabs from UI when their usage doesn't conform to UI guidelines? #445

Open
bugfolder opened this issue Apr 19, 2023 · 0 comments

Comments

@bugfolder
Copy link
Collaborator

The Drupal UI guidelines for vertical tabs (which Backdrop follows) says:

Group subsets of related settings together and put them into vertical tabs, so that only one vertical tab at a time is displaying its form elements.

Use vertical tabs

  • when you have a group of form elements that users can safely ignore, such as metadata elements or elements with good defaults; or
  • for situations similar to the Emails settings on the Accounts settings page [N.B. this refers to admin/config/people/emails]

...
Do not use vertical tabs for the main interaction in the form.
...

Placing functionality that is part of a certain workflow within vertical tabs is discouraged because the user should be able to skip the vertical tabs.

Current Ubercart usage of vertical tabs violates these guidelines in several places:

  • on the Add Product form at node/add/product, the "Product Information" vtab contains many required fields, and the "Shipping settings" vtab contains important information that should be at least reviewed, if not altered;
  • On the Store settings form at admin/store/settings/store, all the fields should be reviewed, and some, like store email address, are required;
  • On the Cart settings form at admin/store/settings/cart, there are several important (non-ignorable) elements;
  • Ditto for admin/store/settings/checkout
  • Ditto for admin/store/settings/products

In order to better conform to UI guidelines, we should consider un-verticalizing the fieldsets on these pages. (This would make #424 unnecessary.)

If we do this, a question is, should the resulting multiple fieldsets be initially collapsed or not collapsed? What seems ideal would be to have them initially uncollapsed to make everything visible, but once the user has reviewed a given page, they are collapsed by default.

@bugfolder bugfolder changed the title Remove vertical tabs from UI when their usage doesn't conform to UI guidelines Should we remove vertical tabs from UI when their usage doesn't conform to UI guidelines? Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant