Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubercart storing uc_store.settings.date_format_uc_store but it should be stored in system.date.formats #507

Open
herbdool opened this issue Oct 29, 2024 · 1 comment · May be fixed by #524

Comments

@herbdool
Copy link
Contributor

In Drupal 7 to Backdrop all variables with the format of date_format_NAME were converted to be stored in system.date like this:

     "formats": {
        "long": {
            "label": "Long",
            "pattern": "l, j F, Y - g:ia",
            "module": "system"
        },

This way the format will appear in the "Date and Time Formats" settings UI. I'm guessing that right now this config isn't exposed anywhere.

herbdool added a commit to herbdool/ubercart that referenced this issue Dec 12, 2024
@herbdool herbdool linked a pull request Dec 12, 2024 that will close this issue
@herbdool
Copy link
Contributor Author

@argiepiano @bugfolder I've got a PR to migrate this variable to system.date. I updated the usage in Ubercart, but I left the old variable there. It's used in uc_bank_transfer which would need the old one for now. When I ported uc_coupon I had already put in a helper to look in both locations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant